Bump paper to 1.21.10 by JonasFranke · Pull Request #234 · AtomPilz-DevTeam/StationofDoomPlugin

JonasFranke · 2025-10-12T10:02:05Z

Paper 1.21.10

Summary by CodeRabbit

Chores
- Updated compatibility to Minecraft 1.21.10.
- Upgraded build tooling to newer versions for improved stability.
Refactor
- Updated internal handling of player head textures to align with latest APIs (no visible behavior changes expected).

coderabbitai · 2025-10-12T10:02:19Z

Walkthrough

Updates build and tooling versions (Paperweight plugin and Minecraft), switches Nix to use gradle_8 with JDK override, adjusts GameProfile property access in ItemBuilder, and removes the publishing repositories block from Gradle while keeping publications.

Changes

Cohort / File(s)	Summary of edits
Build config updates `build.gradle.kts`	Bumped Paperweight Userdev to 2.0.0-beta.18; updated minecraftVersion to 1.21.10; removed publishing.repositories block; retained publications.
Nix devShell Gradle selection `flake.nix`	Switched Gradle reference from gradle.override { java = jdk; } to gradle_8.override { java = jdk; }; no other logic changes.
GameProfile API adjustment `src/main/java/de/j/stationofdoom/util/ItemBuilder.java`	Replaced profile.getProperties() with profile.properties() when putting "textures" in createHead and getHeadBuilder.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

bump mc version to 1.21.3 #173 — Also changes build.gradle.kts minecraftVersion (earlier bump to 1.21.3).
Migrate to flakes #233 — Adjusts flake.nix devShell Gradle/JDK setup, related to this Gradle package change.

Poem

A bunny taps the build with gentle might,
New blocks, new tools, all versions tight.
Nix hops to Gradle 8 in stride,
Profiles preen their texture pride.
Repos trimmed, the burrow’s clean—
Ship it swift, like springtime green! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title concisely and accurately reflects the primary change in the pull request, which is updating the Paper/Minecraft version to 1.21.10, and aligns with the modifications in build.gradle.kts and the PR description. It is specific enough for a reviewer to understand the main purpose at a glance without extraneous details.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch dev/paper1.21.10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2025-10-12T10:03:14Z

Note

Docstrings generation - SUCCESS
Generated docstrings for this pull request at #235

@JonasFranke

Docstrings generation was requested by @JonasFranke. * #234 (comment) The following files were modified: * `src/main/java/de/j/stationofdoom/util/ItemBuilder.java`

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

build.gradle.kts (1)
94-94: Consider updating the API version to match the Minecraft version.

The apiVersion is set to "1.20", but the Minecraft version has been bumped to 1.21.10. Consider updating this to "1.21" to align with the target Minecraft version and ensure compatibility with Paper's API.

Apply this diff:
-    apiVersion = "1.20"
+    apiVersion = "1.21"

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 792019e and eadc3d1.

📒 Files selected for processing (3)

build.gradle.kts (1 hunks)
flake.nix (1 hunks)
src/main/java/de/j/stationofdoom/util/ItemBuilder.java (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: build
GitHub Check: paths-filter
GitHub Check: build

🔇 Additional comments (4)

build.gradle.kts (1)

12-12: LGTM!

The Minecraft version bump to 1.21.10 aligns with the PR objective.

src/main/java/de/j/stationofdoom/util/ItemBuilder.java (2)

92-92: LGTM!

The API change from getProperties() to properties() correctly reflects the updated GameProfile API in Paper 1.21.10.

113-113: LGTM!

The API change from getProperties() to properties() is applied consistently with the change at Line 92.

flake.nix (1)

13-13: LGTM!

Switching to gradle_8 aligns with the Paperweight 2.0.0-beta.18 upgrade, which requires Gradle 8.

coderabbitai · 2025-10-12T10:04:53Z

build.gradle.kts

    id("xyz.jpenilla.run-paper") version "2.3.1"
    id("net.minecrell.plugin-yml.bukkit") version "0.6.0"
-    id("io.papermc.paperweight.userdev") version "1.7.7"
+    id("io.papermc.paperweight.userdev") version "2.0.0-beta.18"


⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify the stability of the beta plugin version.

The Paperweight Userdev plugin version 2.0.0-beta.18 is a beta release. Please verify that this version is stable and suitable for production use, or document any known issues.

🌐 Web query:

Is Paperweight Userdev 2.0.0-beta.18 stable for production use?

💡 Result:

Short answer: No — 2.0.0-beta.18 is a beta pre-release and not intended as a guaranteed production-stable release. Use a stable release (or thoroughly test the beta in your environment) and follow PaperMC guidance to prefer the latest supported non-beta release. [1][2][3]

Sources:

paperweight-userdev docs (shows plugin is maintained and advises using latest supported version). [1]

paperweight GitHub release for v2.0.0-beta.18 (release is labeled beta). [2]

open issue showing known incompatibilities/bugs (example: configuration-cache incompatibility). [3]

Use a stable Paperweight Userdev release
Paperweight Userdev 2.0.0-beta.18 is a pre-release and not guaranteed production-stable. Switch to the latest non-beta version or thoroughly test this beta in your environment and document any known issues.

🤖 Prompt for AI Agents

In build.gradle.kts around line 7 the plugin version is set to the pre-release io.papermc.paperweight.userdev version "2.0.0-beta.18"; replace this with the latest stable non-beta release (check the Paperweight/Userdev release notes or Gradle Plugin Portal for the current stable version) or, if you must keep the beta, add a clear comment above the line documenting that this is a beta, list any known issues, and add a CI/job to run thorough integration tests validating the build against your target Minecraft/Paper versions so the risk is tracked.

Bump paper to 1.21.10

eadc3d1

JonasFranke added the hacktoberfest label Oct 12, 2025

coderabbitai bot added a commit that referenced this pull request Oct 12, 2025

📝 Add docstrings to dev/paper1.21.10

364ef0b

Docstrings generation was requested by @JonasFranke. * #234 (comment) The following files were modified: * `src/main/java/de/j/stationofdoom/util/ItemBuilder.java`

coderabbitai bot mentioned this pull request Oct 12, 2025

📝 Add docstrings to dev/paper1.21.10 #235

Open

coderabbitai bot reviewed Oct 12, 2025

View reviewed changes

JonasFranke merged commit 7860ad2 into master Oct 12, 2025
16 checks passed

JonasFranke deleted the dev/paper1.21.10 branch October 12, 2025 10:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump paper to 1.21.10#234

Bump paper to 1.21.10#234
JonasFranke merged 1 commit intomasterfrom
dev/paper1.21.10

JonasFranke commented Oct 12, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Oct 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

JonasFranke commented Oct 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

JonasFranke commented Oct 12, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 12, 2025 •

edited

Loading

coderabbitai bot commented Oct 12, 2025 •

edited

Loading